fix(accessibility): poll and checkbox structure#17288
Open
joshuai96 wants to merge 3 commits intojitsi:masterfrom
Open
fix(accessibility): poll and checkbox structure#17288joshuai96 wants to merge 3 commits intojitsi:masterfrom
joshuai96 wants to merge 3 commits intojitsi:masterfrom
Conversation
Signed-off-by: Joshua Irmer <[email protected]>
Signed-off-by: Joshua Irmer <[email protected]>
Signed-off-by: Joshua Irmer <[email protected]>
|
Hi, thanks for your contribution! |
Contributor
Author
|
@saghul This is a revive of the other issue, lots has changed regarding accessibility, so i re-did the changes for clean PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a screen reader the polls are not easily perceivable.
This is related to WCAG Success Criterion 1.3.1 Info and Relationships.
The checkbox component now uses the given id, name or a random id to link it's input to the label. This further optimizes the perception with assistive technologies.
The question and answers were not grouped together logically enough for assistive technologies like a screen reader. Wrapping in a form and fieldset with a legend binds them together better instead of the
ulelement. The poll result is logically still an unordered list.The message
There are no polls in the meeting yet. Start a poll here!was wrapped in a<span>. According to the WCAG compliance test, a<span>must only be used inside of<p>(paragraph) to mark specific text passages. A single<span>element as simple text wrapper is discouraged.This is the revive of #15645